search

fsprojects / FSharp.Configuration

The FSharp.Configuration project contains type providers for the configuration of .NET projects.
http://fsprojects.github.io/FSharp.Configuration/
Other
114 stars 63 forks source link

Fixed a round trip serialization problem in SharpYaml #59

Closed Turee closed 8 years ago

Turee commented 9 years ago

SharpYaml deserialized a string "1.0" as double, then serialized it to string "1". The string "1" was deserialized as integer resulting changed type of the field.

forki commented 9 years ago

what about using https://www.nuget.org/packages/SharpYaml/ instead?

vasily-kirichenko commented 9 years ago

We do use SharpYaml.

forki commented 9 years ago

Yep but I meant: shouldn't we use the nuget package instead of putting a dll in lib folder? Or is this a different thing

Turee commented 9 years ago

I'm for the nuget also. I made a pull request to SharpYaml for the bugfix: https://github.com/xoofx/SharpYaml/pull/8

vasily-kirichenko commented 9 years ago

Ah. Initially I put the dll because I made a couple of patches but the author of SharpYaml did not fix and publish the package for a long time. I agree that NuGet package dependency is much better.

Turee commented 9 years ago

Alright that explains it :).