search

fsprojects / FSharp.Control.AsyncSeq

Asynchronous sequences for F#
https://fsprojects.github.io/FSharp.Control.AsyncSeq/
Other
161 stars 59 forks source link

Add ofSeqAsync and concat #99 #102

Closed blumu closed 5 years ago

dsyme commented 5 years ago

Hmmm unrelated test failure on Linux?

Failed   AsyncSeq.merge should fail with AggregateException if a task fails
Error Message:
   Expected: <System.AggregateException>
  But was:  <System.Exception: fail
   at AsyncSeqTests.AsyncSeq-merge should fail with AggregateException if a task fails@1252-5.Invoke(Unit unitVar) in /home/travis/build/fsprojects/FSharp.Control.AsyncSeq/tests/FSharp.Control.AsyncSeq.Tests/AsyncSeqTests.fs:line 1252
   at FSharp.Control.AsyncGenerator.delay@251.FSharp-Control-IAsyncEnumerable`1-GetEnumerator() in /home/travis/build/fsprojects/FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/AsyncSeq.fs:line 252
   at FSharp.Control.AsyncGenerator.append@265-1.Invoke(Unit unitVar0) in /home/travis/build/fsprojects/FSharp.Control.AsyncSeq/src/FSharp.Control.AsyncSeq/AsyncSeq.fs:line 265
   at FSharp.Control.AsyncGenerator.FSharp-Control-AsyncGenerator-AsyncGenerator-1-Apply@188-1.Invoke(Step`1 _arg1)
   at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, FSharpFunc`2 userCode, b result1)
blumu commented 5 years ago

@dsyme Just to confirm: the Travis build failure is unrelated to my change, but is there something I am expected to do in order to fix the Linux build and unblock this PR? Or can we go ahead and merge this PR despite the failure? (I don't have permissions to merge it myself.)

wilsoncg commented 5 years ago

refer to #101 for more info & resolution of travis build failure