fsprojects / FSharp.Control.AsyncSeq

Asynchronous sequences for F#
https://fsprojects.github.io/FSharp.Control.AsyncSeq/
Other
161 stars 59 forks source link

v2.0.4 on Nuget.org? #44

Closed jlewicki closed 8 years ago

jlewicki commented 8 years ago

I see that there is a 2.0.4 release on GitHub, but 2.0.4 is not listed here: https://www.nuget.org/packages/FSharp.Control.AsyncSeq

I'd like to take advantage of the Profile7 PCL support. Any ETA on when we may see 2.0.4 on nuget?

eulerfx commented 8 years ago

Hey @forki or @dsyme I don't seem to have permissions to release. When doing build Release I see the following error:

remote: Permission to fsprojects/FSharp.Control.AsyncSeq.git denied to eulerfx.

dsyme commented 8 years ago

@eulerfx Should now be fixed, you now have push rights to this repo

jlewicki commented 8 years ago

Hello again,

As far as I can tell v2.0.4 still has not been published to nuget? Any chance that could be done soon?

It would be delightful if it was available there so I could reference it from a PCL library.

-John

eulerfx commented 8 years ago

@jlewicki apologies for the delay. I did try pushing the package, but not luck even after permissions were updated. Let me give it another shot.

forki commented 8 years ago

Let me know. I can try to change permissions if needed On Mar 28, 2016 7:25 PM, "Lev Gorodinski" notifications@github.com wrote:

@jlewicki https://github.com/jlewicki apologies for the delay. I did try pushing the package, but not luck even after permissions were updated. Let me give it another shot.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/fsprojects/FSharp.Control.AsyncSeq/issues/44#issuecomment-202495622

eulerfx commented 8 years ago

@forki: Maybe i was doing the wrong thing? What are the steps to publish a nuget package? I was doing fake PublishNuget and got the following output:

---------------------------------------------------------------------
Build Time Report
---------------------------------------------------------------------
Target                  Duration
------                  --------
Clean                   00:00:00.0142442
AssemblyInfo            00:00:00.0197850
Build                   00:00:02.8383899
RunTests                00:00:32.5588570
CleanDocs               00:00:00.0216259
GenerateHelp            00:00:07.1349638
GenerateReferenceDocs   00:00:06.9520890
GenerateDocs            00:00:00.0000832
All                     00:00:00.0000568
NuGet                   00:00:01.1754549
BuildPackage            00:00:00.0002258
PublishNuget            00:00:00.1366100
Total:                  00:00:50.9379089
Status:                 Ok
---------------------------------------------------------------------```

The version on nuget is still 2.0.3 though.
forki commented 8 years ago

IIRC we projectscaffolded the project. Create a release.cmd as described in http://fsprojects.github.io/ProjectScaffold/release-process.html On Mar 28, 2016 7:39 PM, "Lev Gorodinski" notifications@github.com wrote:

@forki https://github.com/forki: Maybe i was doing the wrong thing? What are the steps to publish a nuget package? I was doing fake PublishNuget and got the following output:


Build Time Report

Target Duration


Clean 00:00:00.0142442 AssemblyInfo 00:00:00.0197850 Build 00:00:02.8383899 RunTests 00:00:32.5588570 CleanDocs 00:00:00.0216259 GenerateHelp 00:00:07.1349638 GenerateReferenceDocs 00:00:06.9520890 GenerateDocs 00:00:00.0000832 All 00:00:00.0000568 NuGet 00:00:01.1754549 BuildPackage 00:00:00.0002258 PublishNuget 00:00:00.1366100 Total: 00:00:50.9379089 Status: Ok ---------------------------------------------------------------------```

The version on nuget is still 2.0.3 though.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/fsprojects/FSharp.Control.AsyncSeq/issues/44#issuecomment-202501215

eulerfx commented 8 years ago

@forki Thanks, I just did that and it is now errors with the following:

Error:
System.Exception: fatal: tag '2.0.4' already exists
   at Fake.Git.CommandHelper.gitCommand(String repositoryDir, String command) in C:\code\fake\src\app\FakeLib\Git\CommandHelper.fs:line 62
   at Fake.Git.Branches.tag(String repositoryDir, String tag) in C:\code\fake\src\app\FakeLib\Git\Branches.fs:line 122
   at FSI_0001.Build.clo@281-48.Invoke(Unit _arg3)
   at Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in C:\code\fake\src\app\FakeLib\TargetHelper.fs:line 483
eulerfx commented 8 years ago

I think this may have been caused by a previous failure to release. I bumped it to v2.0.5 and it seemed to have succeeded. Waiting for nuget to update..

eulerfx commented 8 years ago

@forki: it looks like it didn't publish still. I see a release created back in January 13th (https://github.com/fsprojects/FSharp.Control.AsyncSeq/releases) for v2.0.5 which might have been me attempting to release this back then. But still nothing on nuget. I created the release.cmd file as described in the link you sent and ran it successfully. Should I try bumping the version to v2.0.6?

forki commented 8 years ago

looks like you didn't commit the version no. bump in the release notes!? but you are right - it doesn't publish to nuget. Will investigate

forki commented 8 years ago

image

Ok found it. Now the fails for me. Which is correct since I don't have publish rights for this project on nuget. Please pull latest master and run your release.cmd

eulerfx commented 8 years ago

Alright I was able to release.cmd with v2.0.7. Let's see if this pushes it to nuget:

Build Time Report
---------------------------------------------------------------------
Target                  Duration
------                  --------
Clean                   00:00:00.1001341
AssemblyInfo            00:00:00.0239822
Build                   00:00:02.7380658
RunTests                00:00:31.6542800
CleanDocs               00:00:00.0204461
GenerateHelp            00:00:06.9679867
GenerateReferenceDocs   00:00:06.9715628
GenerateDocs            00:00:00.0000942
All                     00:00:00.0000780
ReleaseDocs             00:00:04.3667420
NuGet                   00:00:01.0401061
BuildPackage            00:00:00.0000777
PublishNuget            00:00:00.1319058
Release                 00:00:07.8426080
Total:                  00:01:02.0879610
Status:                 Ok```
forki commented 8 years ago

Mhm doesn't look like it. It seems it doesn't create the packages. Do you see the package in the temp folder?

eulerfx commented 8 years ago

My mistake, I didn't actually merge after fetching upstream. v2.0.8 there now. Thanks a lot!

forki commented 8 years ago

Puhh. Cool. Case closed On Mar 29, 2016 4:09 PM, "Lev Gorodinski" notifications@github.com wrote:

My mistake, I didn't actually merge after fetching upstream. v2.0.8 there now. Thanks a lot!

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/fsprojects/FSharp.Control.AsyncSeq/issues/44#issuecomment-202910694

eulerfx commented 8 years ago

@jlewicki give v2.0.8 a try now.

jlewicki commented 8 years ago

Success!
Thank you gentlemen.