search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 60 forks source link

Update to System.Reactive 4.0 #107

Closed kblohm closed 6 years ago

kblohm commented 6 years ago

Hi, i updated to System.Reactive version 4.0 that was just released. To do so, i had to drop net45 as that is not supported anymore. I also wanted to change some docs, but i could not generate them locally to test. I always get a unknown(1,1): error FS3216: type 'FSharp.CodeFormat.CodeFormatAgent' not found in assembly 'FSharp.CodeFormat, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null'. A possible cause may be a version incompatibility. You may need to explicitly reference the correct version of this assembly to allow all referenced components to use the correct version. I tried some stuff (updating to newer versions of FSF for example) but i did not manage to fix that :/.

panesofglass commented 6 years ago

No worries on the docs. Thanks for your PR. Docs have been broken for some time, unfortunately.

panesofglass commented 6 years ago

I think the App.config can also go away in the tests project.

kblohm commented 6 years ago

I removed the App.config. But i would like to keep net46. I think supporting the same frameworks System.Reactive supports is a good idea in general (although uap is missing here). FAKE also needs net46 for the legacy stuff :).

panesofglass commented 6 years ago

Thanks!

panesofglass commented 6 years ago

I'll work on getting this packaged and shipped.