search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 60 forks source link

Update to Rx 5.0 #158

Closed panesofglass closed 3 years ago

panesofglass commented 3 years ago

NOTE: this drops support for net46, which is not supported by Rx 5.0.

panesofglass commented 3 years ago

@deviousasti should I merge this? I don't remember why I haven't already.

panesofglass commented 3 years ago

Should we include more target frameworks?

deviousasti commented 3 years ago

For Rx5, netstandard2.0 should be sufficient for the runtimes of net472 upto net48, and netstandard2.1 should cover all of .Net Core, the rest is net5, so while this isn't unsafe to merge, paket.lock still pegs Rx at 4.4.1, and not 5.0. 

 System.Reactive (>= 4.4.1) - restriction: || (>= net46) (>= netstandard2.0) (>= uap10.0)

We need to probably run a paket update to bring in 5.0, and then removing net46 would make more sense in a newer release.

panesofglass commented 3 years ago

This now also bumps to F# 5.0.

panesofglass commented 3 years ago

Good comments. Thanks!