fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
285 stars 59 forks source link

Type parameters for Observable.zip are incorrect #17

Closed andybrackley closed 10 years ago

andybrackley commented 10 years ago

I think that the type parameters for Observable.zip are incorrect. Currently it's defined as:

/// Merges two observable sequences into one observable sequence let zip (second: IObservable<'T>) (first: IObservable<'T>) = let inner a b = a, b Observable.Zip(first, second, Func<,,_> inner)

Whereas the Reactive Observable.Zip takes two different type parameters. I therefore think it should be defined as:

/// Merges two observable sequences into one observable sequence let zip (second: IObservable<'U>) (first: IObservable<'T>) = let inner a b = a, b Observable.Zip(first, second, Func<,,_> inner)

panesofglass commented 10 years ago

Good catch!

panesofglass commented 10 years ago

Fixed in #18, thanks!