search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 58 forks source link

Relaxed restriction for `System.Reactive` package to allow versions higher than 5.0 #172

Closed xperiandri closed 7 months ago

xperiandri commented 11 months ago

fixes #169

xperiandri commented 9 months ago

@deviousasti I fixed the issue the simplest way

xperiandri commented 9 months ago

Release a fixed package, please

deviousasti commented 9 months ago

This PR has a 1000+ line changes, the bulk of which is formatting, but I can't simply merge that in without reading through it. Auto-formatting sometimes has weird quirks.

I'll merge it in if you're okay with me reverting the formatting changes. It can be its own PR.

xperiandri commented 9 months ago

OK, I'll submit trailing whitespaces removal as a separate PR

xperiandri commented 8 months ago

@deviousasti I split this into 3 PRs

NickDarvey commented 7 months ago

Any chance of a review and release, @cloudRoutine, @deviousasti, or @panesofglass?

deviousasti commented 7 months ago

Sorry for the delayed response, I'll merge and release.

OkkeHendriks commented 7 months ago

Hey, just wanted to ask if there is any ETA on releasing this?

TeaDrivenDev commented 7 months ago

Is there anything that still needs to happen for this to be released? This fix would be really helpful to have.

kgday commented 4 months ago

This still hasn't been released?

xperiandri commented 4 months ago

@deviousasti ?