search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
285 stars 59 forks source link

Adding fsrx #23

Closed cloudRoutine closed 9 years ago

cloudRoutine commented 9 years ago

I don't have any experience with travis ci, so I'm not sure what I need to do to fix the build failure.

panesofglass commented 9 years ago

@cloudRoutine I'm actually surprised it runs on travis at all. :) I've added the required pieces to get this working there, though I won't promise it'll pass initially. I'm almost done with the merge. One thing that confuses me is that I don't run into any issues using Observable as the module name. What were you hitting that caused you to want to switch to Reactive?

panesofglass commented 9 years ago

@cloudRoutine please check out the changes I made after merging. I lifted Reactive to the namespace and restored Observable as the module name. Please let me know if you have any concerns with this approach.

cloudRoutine commented 9 years ago

I agree, it makes sense to lift the namespace since there's also the Builders module