search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 60 forks source link

Fix document generation #26

Closed panesofglass closed 9 years ago

panesofglass commented 10 years ago

FSharp.Formatting is currently failing. Steps to repro:

  1. Run .\build.cmd Release from the command line
  2. Watch for the stack trace in the build just after docs are generated, specifically as it generates index.fsx
panesofglass commented 10 years ago

Much closer now! Still some things breaking. :(

rodrigovidal commented 10 years ago

@panesofglass I investigated it a little bit, and the problem seems to be a bug in FSharp.Formatting. The problem is the IGroupedObservable in the RxQueryBuilder. If you comment the GroupBy and GroupValBy methods then everything seems to work. There is no problem with references to IGroupedObservable outside the RxQueryBuilder computation expression.

forki commented 10 years ago

wanna fix it? I can merge and release....

2014-09-30 16:51 GMT+02:00 Rodrigo Vidal notifications@github.com:

@panesofglass https://github.com/panesofglass I investigated it a little bit, and the problem seems to be a bug in FSharp.Formatting. The problem is the IGroupedObservable in the RxQueryBuilder. If you comment the GroupBy and GroupValBy methods then everything seems to work. There is no problem with references to IGroupedObservable outside the RxQueryBuilder computation expression.

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/FSharp.Control.Reactive/issues/26#issuecomment-57325825 .

panesofglass commented 10 years ago

I am finally at the same point as @rodrigovidal. Do you see

System.InvalidOperationException: The entity or value 'System.Reactive.Linq.IGroupedObservable`2' does not exist or is in an unresolved assembly. You may need to add a reference to assembly 'System.Reactive.Interfaces'?

What does that mean? How might we resolve it without breaking anything? Is it possible reference the required assembly, and if so, where? /cc @tpetricek

rodrigovidal commented 10 years ago

Yeah, we are at the same point.

dungpa commented 9 years ago

I may have missed something here.

Judging from the error message, you may want to provide containing directory of System.Reactive.Interfaces to https://github.com/fsprojects/FSharp.Control.Reactive/blob/32c53b2c85a73b9099bf9ad59452029e8b94d7e0/docs/tools/generate.fsx#L82? The libDirs parameter provides a list of folders for the purpose of resolving assemblies.

An alternative is to add a FAKE target to copy System.Reactive.Interfaces and dependent assemblies to the bin folder for build API reference.

rodrigovidal commented 9 years ago

Hi @dungpa,

I have to say that I am a FSharp.Formatting newbie. I tried to copy System.Reactive.Interfaces manually to the bin directory and it didn't work.

panesofglass commented 9 years ago

@dungpa, should I leave this open for further refinement? This solution fixed several other projects' issues with FSharp.Formatting, as well.

dungpa commented 9 years ago

No, please close it. I think the use of libDirs should appear in ProjectScaffold to save users from frustration.

panesofglass commented 9 years ago

@dungpa, I submitted https://github.com/fsprojects/ProjectScaffold/pull/92, which has now been merged.