search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 60 forks source link

Added support for rx testing and a few f# rx operators #30

Closed xepaul closed 9 years ago

panesofglass commented 9 years ago

Please remove the .nuget folders and files. We are now using Paket.

panesofglass commented 9 years ago

This looks like some good stuff. Once the NuGet pieces have been rolled back, I'll take a deeper look. Also, I'm not very familiar with the MS Open Tech license. Is porting their code allowed? I assume so given RxJava; just want to check.

panesofglass commented 9 years ago

Also, thanks very much for the tests!

panesofglass commented 9 years ago

As mentioned earlier, I like what I see. However, I'm wondering if this should go into the core package. These look mostly like extensions to Rx, not F# wrappers, which is the intent of the library. Thoughts?

xepaul commented 9 years ago

Possibly, I guess if this is purely F# wrappers for existing rx operators rather than F# support for rx in general. The Rx testing wrapper/port seems like a good addition as a separate assembly, and shows the need to have the relevant operators available with a IScheduler parameter?

panesofglass commented 9 years ago

@xepaul, I agree. I think it can go in this repo, but it should be a separate project in the solution.

panesofglass commented 9 years ago

@cloudRoutine what do you think? Another NuGet package?

cloudRoutine commented 9 years ago

I think adding it as another project in the solution is a good idea. I'd definitely like to see FSharp.Control.Reactive expand to cover a broader scope of Functional Reactive Programming in the future by incorporating libraries for Signal Graphs and Arrowized FRP.

As far as multiple NuGet packages are concerned, are you thinking of a structure where FSharp.Control.Reactive is (eventually) the overarching suite of libraries, with subset packages like FSharp.Control.Reactive.Core ( just the wrappers ) , FSharp.Control.Reactive.Testing, etc.?

xepaul commented 9 years ago

Yep I think it makes sense to be another NuGet package.

panesofglass commented 9 years ago

I would love to get to this one, but it will take me a bit more time as it requires additional changes to the build.fsx file.

cloudRoutine commented 9 years ago

I've been having a ton of trouble getting this PR to work, and the overall structure of the repo has changed since you originally submitted the PR. Try branching off master and making your changes again in a new PR and we'll see if that one can work. Apologies for taking this long to address this, it probably would have been much easier to do this months ago.