search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 58 forks source link

Observable.SubscribeOn overload missing #62

Closed TheAngryByrd closed 9 years ago

TheAngryByrd commented 9 years ago

I just noticed this this other day that this is missing an overload of Observable.SubscribeOn. I would send a PR for it but there's an issue I found doing so.

There are the overloads for observeOn provided

let observeOn (scheduler:Concurrency.IScheduler)
let observeOnContext (context:SynchronizationContext)

There is a "subscribeOn" provided with the SynchronizationContext 

let subscribeOn (context:Threading.SynchronizationContext)

but no version provided with the IScheduler.

If I introduce something like subscribeOnScheduler 

 let subscribeOnScheduler (scheduler:Reactive.Concurrency.IScheduler)

This will now have an odd naming convention, but the other option is to break the existing API.

What do you think we should do?

panesofglass commented 9 years ago

I'd say break it. We could go for a major version number change or file it as a bug fix. Thoughts?

TheAngryByrd commented 9 years ago

I'm OK with breaking if it you are. I'll send a PR soon.

panesofglass commented 9 years ago

Thanks! This will be released as 3.2.0