Support for Profile259 - Githubissues

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.

http://fsprojects.github.io/FSharp.Control.Reactive

Other

284 stars 58 forks source link

Support for Profile259 #65

Closed TheAngryByrd closed 8 years ago

TheAngryByrd commented 9 years ago

This is the initial pull request to address #29 and #54 . This is bound to break things. One of them being support for .net 4.0 Please test aggressively and provide feedback .

[x] Convert projects to Profile259
[ ] Tested on existing apps
[ ] Tested on iOS
[ ] Tested on Android
[ ] Tested on Windows Store Apps
[ ] Tested on Windows Phone 8.1 Apps

panesofglass commented 9 years ago

:+1: thanks!

jlewicki commented 8 years ago

I was wondering if there are any updates on this issue?

I added profile 259 support in my fork (before noticing this issue), but took a slightly different approach of adding a second .fsproj file specific to profile 259. The resulting nuget package keeps the existing lib/net40 folder, and adds lib/portable-net45+win+wpa81+blahblahblah. I though doing it that way would have less of a chance of breaking existing consumers.

Would it be worth creating a separate PR?

cloudRoutine commented 8 years ago

@jlewicki It would, that's the preferable approach

cloudRoutine commented 8 years ago

Unnecessary after #74