fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
285 stars 59 forks source link

Conform more closely to the F# style guidelines. #7

Closed panesofglass closed 11 years ago

panesofglass commented 11 years ago

Remove the top-level module and nested modules in favor of a namespace with an AutoOpen Core module and combinatory module.

panesofglass commented 11 years ago

@dsyme, You noted that the gratuitous overloads could be removed, but I had a hard time trying to sort out how type inference helps there. The underlying .NET libraries seem to require explicit replication. I thought about using an Active Pattern to break apart the various tuple combinations, but a) I wasn't sure if that would introduce a performance issue, and b) I am quite certain you had something else in mind.