search

fsprojects / FSharp.Control.Reactive

Extensions and wrappers for using Reactive Extensions (Rx) with F#.
http://fsprojects.github.io/FSharp.Control.Reactive
Other
284 stars 60 forks source link

Add experimental support for NetStandard #93

Closed TOTBWF closed 6 years ago

TOTBWF commented 7 years ago

System.Reactive already supports netstandard, so this PR updates the build files to both include netstandard as a target, as well as migrating them to the new, pared down fsproj format.

TOTBWF commented 7 years ago

This PR does require MSBuild 15 to compile, which explains why the CI checks are failing, as they use MsBuild 14 and Xbuild 14 (Which is now deprecated)

panesofglass commented 7 years ago

I think the MSBuild 15 issue can be resolved by modifying the appveyor.yml and .travis.yml files. Care to take a crack at it?

panesofglass commented 7 years ago

Looks like a few tests are failing on AppVeyor and Travis, probably related to a binding redirect. Also, please either remove SourceLink or update to the new version that works with .NET Core. Thank you for continuing to work on this!

panesofglass commented 6 years ago

@cloudRoutine it looks as though the config on AppVeyor is causing this to break. It's trying to run build.cmd NuGet, which we replaced with build.cmd Pack in appveyor.yml.

panesofglass commented 6 years ago

@forki do you know why I would see a build error stating, 'Target "NuGet" is not defined.' when I don't have a "NuGet" target?

panesofglass commented 6 years ago

@TOTBWF I just submitted another PR to fix the build. Can you try merging?

TOTBWF commented 6 years ago

Looks like the AppVeyor build is just broken on the pack stage, all the tests pass.

panesofglass commented 6 years ago

@enricosada, we are really close on this. Any chance you could help us figure out what's wrong with pack?

dsyme commented 6 years ago

cc @ChrSteinert too, who is a magician in this knid of work :)

enricosada commented 6 years ago

Let me check

ChrSteinert commented 6 years ago

Seems to be a lot of love has been put into this already! :) I'll see if I can be of any help…

ChrSteinert commented 6 years ago

Is there a specific reason, why the packaging is done via dotnet CLI and not Paket? I got it working locally with Paket …

ChrSteinert commented 6 years ago

I guess this should do it 👍

enricosada commented 6 years ago

@ChrSteinert the dotnet pack should work with paket too (and is the preferred way with .net core sdk). paket is integrated in the sdk, so that will helps (msbuild props like PackageLicenseUrl etc are used, etc)

i tried and i think the issues is <IncludeSymbols>true</IncludeSymbols>, that is used to generate another package (.symbols.nuget), but paket target has a bug with that. Probaly author want to include the pdb, not generate another package for the symbols I'll open and issue in paket repo. meanwhile i'll send a PR to fix this here

enricosada commented 6 years ago

paket bug is https://github.com/fsprojects/Paket/issues/2689