Closed abelbraaksma closed 10 months ago
This is ready, now that the obvious errors are fixed ;)
Added .fantomasignore
in two places (needed for VS 2022 plugin to work). This fixes a (temporary) bug in Fantomas that raises an error because of WhileBang
, see https://github.com/fsprojects/fantomas/issues/3019
Thanks for the review, @bartelink. I'll merge this in as soon as it passes the tests.
I sorted out the issue with the test reports not showing. Reported here: https://github.com/dorny/test-reporter/issues/343 (see my comments). See also this thread: https://github.com/actions/upload-artifact/issues/472
This fixes part of #208, the following signatures are added and implemented (todo: tests)
Note that
skip
andtake
raise if there are not enough elements (just like itsSeq
counterparts) and thattruncate
anddrop
do not raise. Whiledrop
does not exist inSeq
, I felt it make sense astruncate
also exists. Maybe it can be added to F# Core?PS, in case anybody wondered, I chose the name
drop
simply because it exists in Scala. I'm not a fan of Scala per se, but was just looking for existing functions that behave like this one, and indeed, the Scala function does not raise either.See also discussion here: https://stackoverflow.com/questions/1247788/calling-seq-skip-and-seq-take-in-f
TODO list:
TaskSeq.skip
TaskSeq.take
TaskSeq.drop
TaskSeq.truncate