Revert "Bump actions/upload-artifact from 3 to 4"

fsprojects / FSharp.Control.TaskSeq

A computation expression and module for seamless working with IAsyncEnumerable<'T> as if it is just another sequence

MIT License

91 stars 7 forks source link

Revert "Bump actions/upload-artifact from 3 to 4" #212

Closed abelbraaksma closed 8 months ago

abelbraaksma commented 8 months ago

Reverts fsprojects/FSharp.Control.TaskSeq#206

Because of: https://github.com/actions/upload-artifact/issues/472
And: https://github.com/dorny/test-reporter/issues/343
And more info: https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

abelbraaksma commented 8 months ago

This should fix the fact that test reports are not generated. I.e., we see this on all of the recent PRs, including the #206 that we are reverting here (and also: #207, #208 etc) , which seems to have introduced this issue.

abelbraaksma commented 8 months ago

Yep, this solves it, it works. Reported here: https://github.com/dorny/test-reporter/issues/343.