Input object creation with fields coercion

fsprojects / FSharp.Data.GraphQL

FSharp implementation of Facebook GraphQL query language.

http://fsprojects.github.io/FSharp.Data.GraphQL/

MIT License

399 stars 73 forks source link

Input object creation with fields coercion #436

Closed xperiandri closed 1 year ago

xperiandri commented 1 year ago

@valbers have a look if you have time

valbers commented 1 year ago

While I was taking a look, I pulled the changes to a local working copy and tried to build the solution (using ./build.sh on mac os), but some projects were failing seemingly because of conflicting FSharp.Core versions between those referenced by nuget packages (7.0.0) and the one referenced by us directly (6.0.3). I tried to fix that and ended up having to downgrade FsToolkit.ErrorHandling to 2.13. My suggestion would be to keep the older version if possible and user newer versions with a new FSharp.Data.GraphQL major release (which doesn't need to happen much later IMHO). After that, there were other errors:

Incomplete pattern matches on InputParameterValue (Various lines in TypeSystem.fs; case Variable (_) was missing);
SchemaDefinitions GraphQL type definitions were renamed (the suffix "Type" was added to their names, like in String -> StringType) but not updated in src/FSharp.Data.GraphQL.Server.Relay/Connections.fs.

xperiandri commented 1 year ago

@valbers, I fixed the second one

xperiandri commented 1 year ago

@njlr could you review too?

valbers commented 1 year ago

@xperiandri great! Now what about the FsToolkit.ErrorHandling issue?

xperiandri commented 1 year ago

I’m working on that. Is it only for Type Provider?

valbers commented 1 year ago

I’m working on that. Is it only for Type Provider?

I'm not sure what you mean. Anyway, it's about the errors one gets when running ./build.sh.

xperiandri commented 1 year ago

@valbers @njlr @ivelten @mickhansen this PR is ready for review

xperiandri commented 1 year ago

@valbers @njlr @ivelten @mickhansen any feedback?

valbers commented 1 year ago

@xperiandri I'm taking a look at it. It's a lot of changes, so it will take some time but I'm on it. Can you see some of my comments yet? BTW I'm currently not a "requested reviewer" for this PR.

xperiandri commented 1 year ago

I cannot add you unless you make a review yourself first or become a repo member (see invite)

xperiandri commented 1 year ago

@xperiandri great! Now what about the FsToolkit.ErrorHandling issue?

What was your issue? It works fine for me now

valbers commented 1 year ago

@xperiandri great! Now what about the FsToolkit.ErrorHandling issue?

What was your issue? It works fine for me now

The issue was with the incompatibility with .NET 6.0, but now you updated the target framework to .NET 7.0 so it should be no problem now.

xperiandri commented 1 year ago

But .NET 6.0 builds too. As I added multitargeting