Use System.Text.Json instead of Newtonsoft.Json

fsprojects / FSharp.Data.JsonSchema

MIT License

48 stars 6 forks source link

Use System.Text.Json instead of Newtonsoft.Json #4

Closed panesofglass closed 4 years ago

panesofglass commented 4 years ago

As we are essentially overriding nearly everything in Newtonsoft.Json's default serialization settings for F# types, moving to System.Text.Json is mostly a re-implementation to use its converters. This depends on NJsonSchema support for System.Text.Json, which is currently a WIP.

Steps:

[x] NJsonSchema Support
[x] Update type converters to use System.Text.Json converters
[x] Add System.Text.Json converters for F# records and anonymous records

Notes: Migration Guide

panesofglass commented 4 years ago

Should this replace the Newtonsoft.Json implementation, or should this be another option and another package? @baronfel @Tarmil, any thoughts?

panesofglass commented 4 years ago

I'd say go ahead and make the switch. Things are trending towards STJ, and the excellent library that @Tarmil provides covers enough of the gaps that I was concerned with.

Originally posted by @baronfel in https://github.com/panesofglass/FSharp.Data.JsonSchema/pull/5#issuecomment-638851419

isaacabraham commented 4 years ago

This seems good - one less dependency in the chain as well as the perf gains.

panesofglass commented 4 years ago

With no more comments, I'll go ahead and merge. I can always resurrect this later, if there's a need.