search

fsprojects / FSharp.Data

F# Data: Library for Data Access
https://fsprojects.github.io/FSharp.Data
Other
816 stars 288 forks source link

Removing snk file from fsproj references #1389

Closed JosephFerano closed 3 years ago

JosephFerano commented 3 years ago

I accidentally included the snk file in the fsproj, which caused nuget to include the reference when building the nupkg and subsequently deploying it along with the DLL. This led to the snk file being installed in all projects that referenced FSharp.Data.

My apologies.

ReedCopsey commented 3 years ago

@cartermp This, unfortunately, "pollutes" any project with the .snk file if it uses the 4.2.0 nuget package.

ReedCopsey commented 3 years ago

Thanks @cartermp - Any way we can help to get an updated 4.2.1 nuget out? Would be good to not leave this causing issues.

dsyme commented 3 years ago

I've updateded RELEASE_NOTES.md, which, if all is going correctly in the auto-push, should build and push the nuget

dsyme commented 3 years ago

https://github.com/fsprojects/FSharp.Data/commit/d2b1bafb9fda785da369b9fb28b9a382e25d8b61

cartermp commented 3 years ago

It will not unless the assembly info changes as well AFAIK

dsyme commented 3 years ago

It will not unless the assembly info changes as well AFAIK

Pushed changes with 4.2.2

ReedCopsey commented 3 years ago

@dsyme and @cartermp Thank you. New package doesn't have the snk file now.