fsprojects / FSharp.Data

F# Data: Library for Data Access
https://fsprojects.github.io/FSharp.Data
Other
816 stars 288 forks source link

Remove restrictions for getting innerText #1435

Closed LiteracyFanatic closed 2 years ago

LiteracyFanatic commented 2 years ago

This pull request addresses #1292. It seems like the current version of innerTextExcluding' was tightly coupled to some of the implementation details of the Html type provider. In order to avoid breaking the Validate signature didn't change tests, I moved the existing logic to private functions inside HtmlRuntime.fs. Then I added a new simpler implementation to HtmlOperations.fs which doesn't modify the exclusion list or filter on the aria-hidden attribute.

dsyme commented 2 years ago

Fabulous!