search

fsprojects / FSharp.Data

F# Data: Library for Data Access
https://fsprojects.github.io/FSharp.Data
Other
814 stars 288 forks source link

Format all code #1441

Closed nojaf closed 2 years ago

nojaf commented 2 years ago

Hello, would you be interested in using Fantomas for this community project?

nojaf commented 2 years ago

Fantomas is net6 only thing, is there any reason this project is still on net5?

baronfel commented 2 years ago

even if there is a reason for sticking to net5.0 target frameworks, the project itself can and should move to 6.0 SDKs. You can target older TFMs from newer SDKs, you just also get the benefit of any fixes/feature enhancements that came with the newer SDK.

nojaf commented 2 years ago

Right, so I should be able to bump the global json without many consequences right?

baronfel commented 2 years ago

Yes, with a caveat - the PR/merge workflows use the setup-dotnet action to ensure the appropriate version of the .NET SDK is installed. If you change the value in global.json, I would also change these usages over to install multiple .NET SDKs to ensure that tests still run:

- name: Setup dotnet
  uses: actions/setup-dotnet@v2
  with:
    dotnet-version: | 
      5.0.x
      6.0.x
nojaf commented 2 years ago

Right on! Thanks @baronfel. @cartermp and @dsyme let me know what you prefer in this case.

dsyme commented 2 years ago

Reformatting may be needed after pull

Regarding .NET version - we can update it - it might require an update to paket and fake?

cartermp commented 2 years ago

Updating to net6 is possible, it will just be annoying. IIRC this requires FAKE to move to be project-based

dsyme commented 2 years ago

@nojaf Could you reformat after https://github.com/fsprojects/FSharp.Data/pull/1442 please?

@cartermp We should likely just cut FAKE out of this project

dsyme commented 2 years ago

@nojaf I'm doing the update to .NET 6 separately here: https://github.com/fsprojects/FSharp.Data/pull/1443

dsyme commented 2 years ago

@nojaf I'll do the merge and the things I mentioned above, and re-format

dsyme commented 2 years ago

OK this is now ready - I'm happy with the code after formatting, more or less

dsyme commented 2 years ago

I'll make a couple more tweaks to .edtiorconfig in a separate PR

dsyme commented 2 years ago

@nojaf Thank you sooooooo much for pushing this along. It makes the repository so much easier to maintain and contribute to

nojaf commented 2 years ago

You are most welcome. The more projects are formatted, the more exposure for Fantomas 😸.