search

fsprojects / FSharp.Data

F# Data: Library for Data Access
https://fsprojects.github.io/FSharp.Data
Other
806 stars 288 forks source link

Support DateOnly and TimeOnly types #1461

Open nhirschey opened 1 year ago

nhirschey commented 1 year ago

When this is moved to >= .NET6.0, it would be nice to add support for System.DateOnly and System.TimeOnly types. DateOnly in particular, because often a date is just a date.

Mentioning now b/c I see the repackaging major version bump, though maybe requiring net6.0 is not possible because type providers have to stay netstandard2.0.

I could contribute a PR for the functionality when it’s allowed.

cartermp commented 1 year ago

Yeah, if we broke compat with .NET Framework then we could do this I think. But that's a pretty big change to make, and although the majority of F# developers are not using .NET Framework, there are enough to make breaking that existing compat probably not worth it for a while. FWIW if there were no compat with .NET Framework to speak of today, I'd be completely in favor of this and not trying to find a way to add that compat.

nhirschey commented 1 year ago

Makes sense. Backwards compatibility is a great F# feature, and DateOnly is still young.

thanks for considering.