search

fsprojects / FSharp.Data

F# Data: Library for Data Access
https://fsprojects.github.io/FSharp.Data
Other
814 stars 288 forks source link

Update fsdocs #1496

Closed nojaf closed 10 months ago

nojaf commented 10 months ago

Hi there, I've been working on a new theme for FSharp.Formatting. I would like to start rolling out the latest alpha and gather some real-world feedback.

Other examples:

Thanks for considering this PR!

Thorium commented 10 months ago

This PR seems to pass CI and current master doesn't.

nojaf commented 10 months ago

Yes, I believe master doesn't have the fix of https://github.com/fsprojects/FSharp.Data/pull/1496/commits/dc356ce12a7ff24203074849cafd6ac9cdd8f94f

nojaf commented 10 months ago

Not sure what went wrong in https://github.com/fsprojects/FSharp.Data/actions/runs/6855774344/job/18641541374

This works on my local Windows machine.

Thorium commented 10 months ago

I merged the main to my 4 PRs and 2 passed, 2 failed. They all pass in my machine. So this is a random failure.

Thorium commented 10 months ago

It seems to me that it's a network error in WorldBank provider. Not sure why unit tests are doing network requests.

cartermp commented 10 months ago

This should be live now: https://fsprojects.github.io/FSharp.Data/library/XmlProvider.html

nojaf commented 10 months ago

Yes, thank you!

Thorium commented 6 months ago

The current 6.4.0 release build didn't create a NuGet package, because build failed after spending about 6 hours in the document generation phase:

GenerateDocs 05:57:06.9700490 (Failed to generate docs)

Details: https://github.com/fsprojects/FSharp.Data/actions/runs/8258675234/job/22591313017#step:6:1764

nojaf commented 6 months ago

Mildly interesting, you could try and update to v20 stable and see if that helps.