fsprojects / FSharp.Data

F# Data: Library for Data Access
https://fsprojects.github.io/FSharp.Data
Other
814 stars 288 forks source link

WorldBank provider is broken (their API changed to https) #1514

Closed pkese closed 1 day ago

pkese commented 1 week ago

WorldBank stopped responding to http requests, but is responding to https.

https://github.com/fsprojects/FSharp.Data/blob/71c95c7264cbda846bb675fe177a639d04b94e67/src/FSharp.Data.DesignTime/WorldBank/WorldBankProvider.fs#L31

The above url needs to change to https.

pkese commented 1 week ago

To validate (in case it was a temporal failure):

http: http://api.worldbank.org/v2/en/country/us;cw;zh;ye/indicator/NY.GDP.MKTP.PP.CD?mrv=1&per_page=550

https: https://api.worldbank.org/v2/en/country/us;cw;zh;ye/indicator/NY.GDP.MKTP.PP.CD?mrv=1&per_page=550

Thorium commented 6 days ago

Yes, the current build fails without this.

pkese commented 2 days ago

@dsyme @cartermp any chance of pulling either #1515 or #1516 and making a new release?

We have an issue:

dsyme commented 1 day ago

@pkese @Thorium For a new release please bump the release notes, and we can crank the handle (it should basically be automatic)