search

fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
462 stars 155 forks source link

FSharp.Formatting NuGet packages requires specific version of FSharp.Compiler.Service #771

Closed object closed 1 year ago

object commented 1 year ago

Prior version 15.0.0 FSharp.Formatting NuGet package had a dependency on version of FSharp.Compiler.Service >= 40.0.0, so any higher version of FShapr.Compiler.Service fit. Newer versions of FSharp.Formatting require specific versions of FSharp.Compiler.Service, e.g.:

15.0.0 -> 41.0.3 15.0.1 -> 41.0.4 ... 16.1.0 -> 41.0.5 16.1.1 -> 41.0.5

Is there a reason for such strict dependency? It complicates version resolution process and sometimes makes impossible to use latest versions of core FSharp libraries.

dsyme commented 1 year ago

Hmmmm not sure. It could be loosened.

The problem is, FCS right now has no real binary compat promise, even between minor versions, so we may be exposed to breaking changes. It's somewhat unlikely given the parts of the FCS API we're using but it can happen.

dsyme commented 1 year ago

Which parts of which FSharp.Formatting packages are you using?

object commented 1 year ago

Not using directly, through one of the libraries. I will check tomorrow.

object commented 1 year ago

I checked our usage of the package, and in fact it's no longer in use in our solution, must be something we used in the past. Based on your explanation about risk of breaking changes, I am closing the issue.