search

fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
462 stars 155 forks source link

Fixes for <exclude/> support, with tests and docs. #787

Closed davedawkins closed 1 year ago

davedawkins commented 1 year ago

Documentation on rebasing links Issues #786 , #785

davedawkins commented 1 year ago

All updates made as requested. Thank you for the constructive feedback, and sorry for the typos and silly mistakes

nhirschey commented 1 year ago

Thanks so much @davedawkins. @nojaf sure, I should be able take a look in a few hours.

davedawkins commented 1 year ago

Please hold off from applying this PR. I think I've found an issue with excluding type.

davedawkins commented 1 year ago

There's no issue with excluding type as such, but the enclosing module will still list an excluded type. Additionally, the search index is listing excluded items, so I'm going to fix both those issues today. Unless requested otherwise, I'm going to check those changes into this branch (and hence this PR).

nojaf commented 1 year ago

Hello @davedawkins, thank you so much for your persistence here!

I think having the index changes in this PR is ok. I took a peek at the latest changes and everything is still ok for me.

davedawkins commented 1 year ago

@nojaf, no problem. I'm determined to get Sutil's API documented! Thank you for your help too.

nhirschey commented 1 year ago

Wonderful set of fixes @davedawkins. Thank you! It looks good to me as well.

I went ahead and merged the PR to trigger the release. It should hit the feed soon.