fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
462 stars 155 forks source link

_menu-item_template _menu_template oddities #803

Open TheAngryByrd opened 1 year ago

TheAngryByrd commented 1 year ago

👋 Playing around with the menu templating from https://github.com/fsprojects/FSharp.Formatting/issues/754 and I've noticed a few oddities.

  1. Both of these these templates get copied to the output folder:
  copying C:\Users\jimmy\Repositories\public\TheAngryByrd\fsdocstster\build\..\docsSrc\_menu-item_template.html --> .\_menu-item_template.html
  copying C:\Users\jimmy\Repositories\public\TheAngryByrd\fsdocstster\build\..\docsSrc\_menu_template.html --> .\_menu_template.html
  1. They do not update the page during watch mode:

https://user-images.githubusercontent.com/1490044/222463040-3a9610f8-f5ee-4f70-960e-b1389663d6fc.mp4

nojaf commented 1 year ago

Hi there,

For 1. definitely a problem. As for 2. this did work for me. The reload does take a while but eventually comes through.

It might also just be another sign that we should refactor some of the watch bits to something more adaptive 🙈.

TheAngryByrd commented 1 year ago

So i think some of my issues with this tool are the fact that the working directory has to be the root of the repository. Similarly, other things seem to stop working (like github links to src files in API references) if you don't have it at the root.