fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
464 stars 155 forks source link

One fsiEvaluator per docs file #807

Closed nhirschey closed 1 year ago

nhirschey commented 1 year ago

I am pretty sure this fixes https://github.com/fsprojects/FSharp.Formatting/issues/737. Instead of creating one fsiEvaluator per docs build, I moved fsiEvaluator creation inside the processFile function. Thus, one evaluator per file.

Anecdotally, I have a site with lots of docs files that has been stuck on fsdocs version 15.0.0. Any version $\ge15.0.1$ caused the fsdocs build process to fail with a stack overflow that seemed to be related to collecting script parsing/fsc results in a list. With this PR, the site finally builds on a recent fsdocs version.