search

fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
462 stars 155 forks source link

Update Dockerfile #831

Closed kMutagene closed 10 months ago

kMutagene commented 10 months ago

This PR updates the Dockerfile used for binder.

I cannot think of any real way to test this, as a full repo with gh pages would have to be set up with this.

However, Plotly.NET uses this dockerfile, and you can see in the docs pages that you can open and execute the notebooks on binder. See for example: https://plotly.net/distribution-charts/violin-plots.html (click on 'run in binder')

closes #827

nhirschey commented 10 months ago

The violin page errors out for some reason, but I was able to run the plotly.net index page on binder to confirm it works. Looks good to me.

The release should be bumped to 18.1.2 to include this.

@nojaf regarding publishing it gets included with fsdocs tool (see here) and deployed to the site by default. For fantomas it's in the gh-pages branch here.

nojaf commented 10 months ago

Oh I see, thanks for the pointer @nhirschey!

nojaf commented 10 months ago

Thanks a bunch @kMutagene!