search

fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
462 stars 155 forks source link

Output font size on mobile safari is too big #889

Closed nhirschey closed 5 months ago

nhirschey commented 7 months ago

Maybe my phone is weird, but I’m not seeing raw fsi output scaling correctly in docs. See screenshot from the csv provider below. The green “HLOC” output text font size is too big compared to the body text and fsharp code block.

I cannot reproduce this with small window sizes desktop edge browser, but I consistently get it with my iPhone.

image

nojaf commented 7 months ago

Hi @nhirschey, thanks for the report. Could you give me the exact link to this page? I'll take a look.

nhirschey commented 7 months ago

Thanks @nojaf https://fsprojects.github.io/FSharp.Data/library/CsvProvider.html

It seems to happen when the output is bigger than the window. Also see my teaching site here. Simple tuple output like ‘ val it: int * int = (1, 2)’ is formatted correctly but if you scroll down fsi output for ‘simpleReturnTuple’ is too big.

image

nhirschey commented 6 months ago

Another example in compiler docs release notes, the snippet font size on this page is all too big

https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html

nojaf commented 6 months ago

Thanks, the problem here is that I need to see this in Safari to be able to address it. I should try and have a screen sharing session with someone that has a Mac. I can't reproduce this in the Chrome emulator, so I believe the problem is a browser styling default that we still need to override.

nojaf commented 5 months ago

Hi @nhirschey, could you try https://www.nuget.org/packages/FSharp.Formatting/20.0.0-alpha-017 on your personal website? It might improve things.

nhirschey commented 5 months ago

Hi @nojaf, thanks for giving this a shot. I upgraded to alpha 17 but the problem is still there unfortunately.

Ex the “ val x: RecordExample …” output at https://nhirschey.github.io/Teaching/fundamentals.html#Records