search

fsprojects / FSharp.Formatting

F# tools for generating documentation (Markdown processor and F# code formatter)
https://fsprojects.github.io/FSharp.Formatting/
Other
462 stars 155 forks source link

Fix sizing of code elements inside headers. #905

Closed teo-tsirpanis closed 3 months ago

teo-tsirpanis commented 4 months ago

Fixes formatting when code elements are used inside elements that have a different font size like headers.

nojaf commented 4 months ago

Hi, this was done rather deliberately for Safari. Can you please submit a before and after screenshot of this change? I'd like to know more about the context here.

teo-tsirpanis commented 4 months ago

Before: image

After: image

nojaf commented 3 months ago

Thanks, I would prefer to go with:

h1 code, h2 code, h3 code, h4 code, h5 code, h6 code {
    font-size: inherit;
}

instead as the font-size is now set deliberately to fix https://github.com/fsprojects/FSharp.Formatting/issues/889.

teo-tsirpanis commented 3 months ago

Feedback addressed @nojaf.

teo-tsirpanis commented 3 months ago

I can wait for a few weeks, there's no immediate need to make a release just for this.

nojaf commented 3 months ago

Alright thanks!