search

fsprojects / FSharp.Json

F# JSON Reflection based serialization library
Apache License 2.0
222 stars 26 forks source link

Created a fork #51

Closed NicoVIII closed 2 years ago

NicoVIII commented 3 years ago

Hi!

I hope this is okay, but I forked the project, started to make changes I wanted for my projects and added my style to the current implementation. I also created a Nuget release of my version, I hope I credited you right.

If there are problems with what I'm doing, please tell me so I can solve those! I don't want to offend anyone but because the projects seems to be in a sleeping state right now, I thought I can create my own version for now. I'm happy to contribute my changes back, but at the moment this is a little too much work, because one of the first things I did was to reformat the code with Fantomas, so I could not cherry-pick individual additions into own branches and MRs, that's why I'm opening this big one, if you are interested in what I'm doing.

Sorry for the wall of text!

vsapronov commented 2 years ago

I don't mind to add some features like support for ResizableArray or support for null/None values from untyped objects. However reformatting and all these tools integrations - that is beyond what I'm ready to do...

NicoVIII commented 2 years ago

That's totally fine with me! I didn't expect you to adjust to my personal style of programming.

I opened another PR with the ResizeArray support only: #57

I will close this PR.