search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Testing types are internal and need to be source included in the place you want to use them #222

Closed 7sharp9 closed 6 years ago

7sharp9 commented 6 years ago

Description

Testing types are internal and need to be source included in the place you want to use them

Repro steps

Try using the Testing types from your testing assembly

Expected behavior

You should be able to instantiate testing types without having to source include the sdk in more than one assembly

Actual behavior

You have to source include in more than one assembly, this can pose issues such as the same type existing in more than one assembly

Known workarounds

Copy and paste parts of the code.

Fix is easy remove internal from ProvidedTypesTesting and its static members.

dsyme commented 6 years ago

After #228 ProvidedTypesTesting.fs should only be included in your test assembly, and not int he type provider itself.

Testing is made internal again though it doesn't really matter if it's internal or not

7sharp9 commented 6 years ago

Hmm, well I guess I need to fork then :-(