search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Fix for #230 #231

Closed 7sharp9 closed 6 years ago

dsyme commented 6 years ago

@7sharp9 Could you add a test as well?

7sharp9 commented 6 years ago

I'll see if I can find a bit of time today to write a test to exercise the addition

dsyme commented 6 years ago

@7sharp9 Any luck with the testing? If it turns out really hard to test we can merge, but it would be really great to get a test added, e.g. to keep this working if we ever rewrite the SDK again

7sharp9 commented 6 years ago

@dsyme Sorry I never had time yesterday debugging quotation splicing I'll see if I can make a test today if I can.

7sharp9 commented 6 years ago

Im struggling with the tests, the size of providedtypes.fs make working with it really tough, vs4mac, ionide and rider all crawl to a halt.

Im also having trouble with making a test, I get a:

The design-time type 'System.Collections.Generic.List`1[System.Object]' utilized by a type provider was not found in the target reference assembly set

And Im not sure where this is coming from as vs4mac terminates as I try to debug.

7sharp9 commented 6 years ago

@dsyme Is there some sort of assembly redirects thats not happening in tryGetTypeFromAssembly?

The design-time type 'System.Collections.Generic.List`1[System.Object]' utilized by a type provider was not found in the target reference assembly set '[tgt assembly mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;\n tgt assembly System.Numerics, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;\n tgt assembly System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;\n tgt assembly System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;\n tgt assembly System.Xml.Linq, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;\n tgt assembly System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;\n tgt assembly FSharp.Core, Version=4.4.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a;\n tmp6qXu1e]'. You may be referencing a profile which contains fewer types than those needed by the type provider you are using.