search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Add Get custom attribute fails test #239

Closed 7sharp9 closed 6 years ago

7sharp9 commented 6 years ago

Fixes #240

7sharp9 commented 6 years ago

ping?

dsyme commented 6 years ago

Do you know why the test is failing? master seems to be passing

C:\projects\fsharp-typeproviders-sdk\examples\BasicProvider.Tests\BasicProvider.Tests.fs(23,20): error FS3033: The type provider 'ProviderImplementation.BasicGenerativeProvider' reported an error: Could not open file for writing (binary mode): > C:\Users\appveyor\AppData\Local\Temp\1\tmpD260.dllSystem.IO.IOException: The process cannot access the file 'C:\Users\appveyor\AppData\Local\Temp\1\tmpD260.dll' because it is being used by another process. at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle) at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) at ProviderImplementation.ProvidedTypes.BinaryWriter.writeBinaryAndReportMappings[a,b,c,d,e](String outfile, ILGlobals ilg, FSharpOption`1 pdbfile, a portablePDB, Boolean embeddedPDB, b embedAllSource, c embedSourceList, d sourceLink, Boolean emitTailcalls, Boolean deterministic, Boolean showTimes, e dumpDebugInfo, ILModuleDef modul) [C:\projects\fsharp-typeproviders-sdk\examples\BasicProvider.Tests\BasicProvider.Tests.fsproj]

7sharp9 commented 6 years ago

@dsyme Hmm Im using GenerativePropertyProviderWithStaticParams in my test and its locking a temp dll? Test passes for me when I run it in rider with the others though.

7sharp9 commented 6 years ago

@dsyme All clear now must have just been the usual CI foibles

dsyme commented 6 years ago

Thanks for this!

ovatsus commented 6 years ago

After I update to this version, I start to get a lot of warnings like this: The instantiation of the generic type 'Attributes' is missing and can't be inferred from the arguments or return type of this member. Consider providing a type instantiation when accessing this type, e.g. 'Attributes<_>'

dsyme commented 6 years ago

@ovatsus OK, thanks, I'll get it fixed and add warnaserror

7sharp9 commented 6 years ago

Sorry, I think I fixed this in my fork but forgot about the dangling branch/pr

On Thu, 6 Sep 2018 at 17:43, Don Syme notifications@github.com wrote:

@ovatsus https://github.com/ovatsus OK, thanks, I'll get it fixed and add warnaserror

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.TypeProviders.SDK/pull/239#issuecomment-419162537, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj7yoHjWKuwA7lNZ7OuceYmMHsbXXfSks5uYVCsgaJpZM4VPQnj .