search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Use the underlying MethodInfo's attributes as the source of custom attributes #252

Closed 7sharp9 closed 5 years ago

7sharp9 commented 6 years ago

This allows code that uses advanced reflection to still work rather than hit the unimplemented exception

dsyme commented 6 years ago

Could you add the same to ConstructorSymbol too please? Thanks

dsyme commented 6 years ago

@7sharp9 Where possible it's good if this can also be pinned down via testing

7sharp9 commented 5 years ago

Yep, not sure when I’ll have time for the tests as it may be harder to test on ‘normal’ sdk usages rather than the stuff I’m doing in Falanx.

On Tue, 11 Sep 2018 at 11:50, Don Syme notifications@github.com wrote:

@7sharp9 https://github.com/7sharp9 Where possible it's good if this can also be pinned down via testing

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.TypeProviders.SDK/pull/252#issuecomment-420231914, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj7yueC7yAiCWpM17DTdzho_F1-IPwtks5uZ5WLgaJpZM4We7Hs .

7sharp9 commented 5 years ago

Hmm, test should just be getting a methodinfo/ctor info from the genned types I think

7sharp9 commented 5 years ago

I seem to have mangled my branch, I'll make a new PR with these two in and possibly a test for them both.