check 'this' for generative constructors, add try/finally with fixes

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers

https://fsprojects.github.io/FSharp.TypeProviders.SDK/

MIT License

298 stars 94 forks source link

check 'this' for generative constructors, add try/finally with fixes #258

Closed dsyme closed 5 years ago

dsyme commented 5 years ago

Add testing that checks that "this" is available for generative TP constructors, as part of investigating https://github.com/fsprojects/FSharp.TypeProviders.SDK/issues/218

dsyme commented 5 years ago

This also includes the implementation of try/finally support from https://github.com/fsprojects/FSharp.TypeProviders.SDK/pull/242 with fixes.

The tests from that PR haven't yet been included but a smoke test is done and I checked the code by hand. But we should integrte honest code generation tests too