search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Add more reflection capabilities so that MethodSymbol and ConstructorSymbol do not throw when you access GetCustomAttributes #267

Closed 7sharp9 closed 5 years ago

7sharp9 commented 5 years ago

@dsyme I have a test for both of these, do you just want them added as part of GenerativePropertyProviderWithStaticParams generates for correctly or do you want me to add a new explicit test for them?

dsyme commented 5 years ago

@7sharp9 You know me - if I was doing it myself fast I'd just whack them into an existing test. If you ask me what's the "right" thing to do then of course a new test.

So in other words I don't mind :)

7sharp9 commented 5 years ago

@dsyme Separate test it is then :-) I like that a separate test gives you a specific workflow on a unit of functionality, especially with the complexities of this SDK. See #268