Fix assembly names in map for generative provider template

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers

https://fsprojects.github.io/FSharp.TypeProviders.SDK/

MIT License

298 stars 94 forks source link

Fix assembly names in map for generative provider template #271

Closed Liminiens closed 5 years ago

Liminiens commented 5 years ago

This fixes the assembly name for generative provider in assembly map in dotnet template. However, I am not so sure, if the Runtime assembly should be used as a replacement, because I couldn't find information on that. That question was raised when @sergey-tihon fixed some issues in my provider and it's strange that it works either way (JsonProivder.Runtime or JsonProvider). Basic provider uses the Runtime assembly, though.

@dsyme

sergey-tihon commented 5 years ago

@dsyme Could you please review/approve this change? I think that it is correct, but would be nice to validate with you.

P.S. I can merge and release new version of template after approval from your side.

dsyme commented 5 years ago

This is a correct change, thank you!!!

dsyme commented 5 years ago

@sergey-tihon Can you release? thanks!

sergey-tihon commented 5 years ago

Thank you @Liminiens for contribution!

sergey-tihon commented 5 years ago

Released in FSharp.TypeProviders.Templates 5.2.0