fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

try use ReferencedAssemblies #305

Closed dsyme closed 5 years ago

dsyme commented 5 years ago

This is a possible fix for #297

The TP config does report the ReferencedAssemblies, but IIRC there were some situations where the F# compiler was not correctly filling in this value. I've checked the code however and can't see why this would be the case.

Actually, it looks like I might have fixed this in 2016 just forgot to remove the hack fro the TPSDK https://github.com/Microsoft/visualfsharp/pull/1037, or didn't want to remove it since old tooling still needed it.

Anyway, let's see if the TPSDK passes with this in place.

dsyme commented 5 years ago

This makes me feel so much better.

I can imagine :)