fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Support for netcoreapp3.x #328

Closed isaacabraham closed 2 years ago

isaacabraham commented 4 years ago

The type provider template has support for netstandard2.0 and netcoreapp2.0. It would be good to move to netcoreapp3.0 as well.

realvictorprm commented 4 years ago

That early?

Isaac Abraham notifications@github.com schrieb am So., 22. Dez. 2019, 16:19:

The type provider template has support for netstandard2.0 and netcoreapp2.0. It would be good to move to netcoreapp3.0 as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fsprojects/FSharp.TypeProviders.SDK/issues/328?email_source=notifications&email_token=AGB4Z4GQO4FXID2VO3JRMSTQZ6APHA5CNFSM4J6MHHI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICGCTVQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGB4Z4DOZG4NKOTJDN6JIALQZ6APHANCNFSM4J6MHHIQ .

sergey-tihon commented 4 years ago

Why do no think that it is early? I guess it means 3.1 only for design time component, that is LTS and will be supported till ~2022. With MS recommendation uses latest SDK, I believe most of people who use .net core already has 3.1 installed.

sergey-tihon commented 4 years ago

@isaacabraham new template is release (v6.0.0). Can you please try it and confirm that it works for you too?

new steps

dotnet new --install FSharp.TypeProviders.Templates::6.0.0
dotnet new typeprovider -n LemonadeProvider

cd LemonadeProvider

dotnet tool restore
dotnet paket update
dotnet build -c release

dotnet test -c release

dotnet paket pack nuget --version 0.0.1
isaacabraham commented 4 years ago

Will do. If it works I might consider porting the Azure Storage TP over to it - currently that project is basically blocked.

sergey-tihon commented 4 years ago

@isaacabraham does it work for you?

dsyme commented 2 years ago

Fixed now (testing is net5.0, TP is netstandard2.1)