search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

Is embedded resource functionality broken? #364

Closed nhirschey closed 2 years ago

nhirschey commented 2 years ago

Description

Caveat: I would not be surprised if I am making a stupid mistake.

I am struggling to get json resources properly embedded into nugets for FSharp.Data.Toolbox.Twitter (see lines here). The type provider works locally but cannot find the resources when run on a different machine than the one the nuget was built on.

The symptoms are the same as this issue from FSharp.Data that was fixed with this commit to the TypeProviders.SDK in fall 2019.

I am filing this issue because I noticed that @Tarmil's 2019 FSharp.Data test for the fix fails when I run it in the current FSharp.Data repo. That might indicate an issue with the current TypeProvider.SDK.

I have a branch where I added Tarmil 's tests to the FSharp.Data.Test project that is supposed to check embedded resources. Tarmil's tests fail (they pass when I run his 2019 version of the repo).

Repro steps

Clone my embeddedresource-2021 branch of FSharp.Data and run dotnet fake build -t RunTests https://github.com/nhirschey/FSharp.Data/tree/embeddedresource-2021

nhirschey commented 2 years ago

Apologies, I seem to be mistaken. I just now tried using paket to lock to the Sept 2019 TypeProvider.SDK files. I am still getting embedded resource errors in my version of Tarmil's test, so it's highly likely my own error somewhere.