search

fsprojects / FSharp.TypeProviders.SDK

The SDK for creating F# type providers
https://fsprojects.github.io/FSharp.TypeProviders.SDK/
MIT License
298 stars 94 forks source link

ProvidedTypeBuilder.MakeGenericType should use t.MakeGenericType when… #377

Closed thinkbeforecoding closed 2 years ago

thinkbeforecoding commented 2 years ago

… all types are not provided

There was a problem in the WsdlProvider with building Task using ProvidedTypeBuilder.MakeGenericType ... The generated type was not seen as equal to Task and AST compilation was failing because of type mismatch.

This PR is detecting when all types are not Provided and simply calls t.MakeGenericType(..) in this case.

cartermp commented 2 years ago

ah, this was targeted at master, which is not the main branch. I can cherry pick this over

cartermp commented 2 years ago

Never mind, my bad, morning brain before 2nd coffee