DRAFT: adjust to find upcast new redundant

fsprojects / FSharpLint

Lint tool for F#

https://fsprojects.github.io/FSharpLint/

MIT License

303 stars 73 forks source link

DRAFT: adjust to find upcast new redundant #577

Open jp-fournier-dev opened 1 year ago

jp-fournier-dev commented 1 year ago

Don't raise redundant new keyword if in an upcast expression and the type implements IDisposable
Add test to cover this use case

Fixes #572

knocte commented 1 year ago

Good work! Is this PR finished? I ask because it's still marked as DRAFT, but I feel it can already be merged since you added a unit test and your code doesn't break any (old&new) tests.

jp-fournier-dev commented 1 year ago

It does add a test but doesn’t really add anything. I’ll make it work properly and then we can merge and fix the issue