fsprojects / FSharpLint

Lint tool for F#
https://fsprojects.github.io/FSharpLint/
MIT License
303 stars 73 forks source link

Create an API layer for external process (eg: FsAutoComplete) #627

Open MrLuje opened 9 months ago

MrLuje commented 9 months ago

Description

Today, there is no more integration with ionide F# plugin (through FsAutoComplete). With the current implementation (FSAC directly referencing FSharpLint.Core), it means both FSharpLint & FSAC must share the same version of FSharp.Compiler.Service.

As discussed in https://github.com/fsharp/FsAutoComplete/issues/942, an alternative solution could be to implement a API layer between FSharpLint.Core & FSAC, so FSharp.Compiler.Service could be abstracted using dedicated types (same solution that Fantomas is using)

To summarize the integration with FSAC this new API :

sequenceDiagram
    box green FsAutoComplete process
    participant FsAutoComplete
    participant FSharpLint.Client
    end
    box blue FSharpLint process
    participant FSharpLint.Console
    end
    FsAutoComplete->>FSharpLint.Client: GetDaemon
    FSharpLint.Client->>FSharpLint.Console: Start Daemon
    FSharpLint.Console-->>FSharpLint.Client: 
    FSharpLint.Client->FSharpLint.Console: Setup jsonrpc
    FSharpLint.Console-->>FSharpLint.Client: 
    FSharpLint.Client-->>FsAutoComplete: 
    Note over FsAutoComplete,FSharpLint.Client: Later, when a lint is needed
    FsAutoComplete->>FSharpLint.Client: LintRequest
    FSharpLint.Client->>FSharpLint.Console: LintRequest
    FSharpLint.Console->>FSharpLint.Console: Lint with FSharp.Compiler.Service
    FSharpLint.Console-->>FSharpLint.Client: LintResponse<br/>(no FSharp.Compiler.Service types here)
    FSharpLint.Client-->>FsAutoComplete: LintResponse

TODO:

I would like a confirmation that this feature is ok for you guys and I'm willing to work on it

knocte commented 9 months ago

Hello @MrLuje! Yes, this would be very useful so that, if we lag behind again about updating to the last versions of FCS, the last version of the IDEs can still use FSharpLint.

So please go ahead and work on this, we will happily accept PRs. (Side note: we're probably going to merge some work soon that updates FSharpLint to the latest version of FCS; but regardless of that, and as I said above already, your work will still be valuable anyway; only thing to take in account is that if we merge our PRs before yours, you might need to rebase your work.)