search

fsprojects / FSharpLint

Lint tool for F#
https://fsprojects.github.io/FSharpLint/
MIT License
300 stars 73 forks source link

Ignore comments/blank lines when counting number of lines #644

Closed webwarrior-ws closed 6 months ago

webwarrior-ws commented 6 months ago

Fixes https://github.com/fsprojects/FSharpLint/issues/634

knocte commented 6 months ago

Two things @webwarrior-ws and/or @Mersho: 1) Please update documentation to reflect the new way to configure the rule (informing about the fact that the attributes skipBlankLines/skipComments were included in v0.23.0 please). 2) What happens if someone configures the rule in the old way? (the JSON that doesn't include skipBlankLines/skipComments?

webwarrior-ws commented 6 months ago

2. What happens if someone configures the rule in the old way? (the JSON that doesn't include skipBlankLines/skipComments?

These options will be set to false

knocte commented 6 months ago

These options will be set to false

Ok, let's add this to the documentation (altho I think @Mersho was doing that?)

knocte commented 6 months ago

(informing about the fact that the attributes skipBlankLines/skipComments were included in v0.23.0 please).

Mersho you missed this ^