search

fsprojects / FSharpLint

Lint tool for F#
https://fsprojects.github.io/FSharpLint/
MIT License
303 stars 73 forks source link

DRAFT: paket move to FAKE-only #680

Open webwarrior-ws opened 8 months ago

webwarrior-ws commented 8 months ago

Move from paket to Central Package Management.

knocte commented 8 months ago

@webwarrior-ws can you try removing NU1605 now please?

webwarrior-ws commented 8 months ago

@webwarrior-ws can you try removing NU1605 now please?

@knocte where is it?

knocte commented 8 months ago

@knocte where is it?

https://github.com/fsprojects/FSharpLint/blob/58dd6b6704f2787c8c1dfdfa838ba28e29847dc5/Directory.Build.props#L9

You were lucky that I was not afk now :) but please, next time, for obvious questions use grep ;)

webwarrior-ws commented 8 months ago

Build fails with multiple errors if I remove NU1605 from <NoWarn>

knocte commented 8 months ago

Build fails with multiple errors if I remove NU1605 from <NoWarn>

Aren't those easier to resolve now that there's no paket?

knocte commented 8 months ago

If the last commit worked, then it shouldn't be marked as WIP anymore.

BTW when writing commit messages, if you are explaining 2 things that the commit does, please list them with bullets. Otherwise just listing each in a sentence, in the same paragraph, simply separated with a dot (with no way to join the sentences such as "hence", or something) feels kinda strange.

knocte commented 8 months ago

Good work wrt "build: re-enable NU1605" commit. Now, looking at it, it looks fairly simple. Are you sure we cannot separate into its own PR (aka: do it in master while it still paket-based)?

webwarrior-ws commented 8 months ago

Good work wrt "build: re-enable NU1605" commit. Now, looking at it, it looks fairly simple. Are you sure we cannot separate into its own PR (aka: do it in master while it still paket-based)?

I tried, and it didn't work. Microsoft.Build.* versions are set by Visual Studio and cause package downgrades.

knocte commented 8 months ago

I tried, and it didn't work. Microsoft.Build.* versions are set by Visual Studio and cause package downgrades.

I never mentioned VS here. The topic is paket vs CPM (at CI level).

webwarrior-ws commented 8 months ago

I tried, and it didn't work. Microsoft.Build.* versions are set by Visual Studio and cause package downgrades.

I never mentioned VS here. The topic is paket vs CPM (at CI level).

NU1605 was disabled because build in Visual Studio failed. See 58dd6b6

smoothdeveloper commented 8 months ago

Note about <NoWarn>$(NoWarn);...</NoWarn>, I think it is almost always better to use <WarningsNotAsErrors>$(WarningsNotAsErrors);...</WarningsNotAsErrors> instead.

knocte commented 8 months ago

NU1605 was disabled because build in Visual Studio failed.

If you remove that NoWarn in master, then CI doesn't build. So we're talking about CI here, not VS.

webwarrior-ws commented 7 months ago

CI failure seems to be a random bug - CI run for the same commit in cpm-rebased-2 branch is successful: https://github.com/webwarrior-ws/FSharpLint/actions/runs/7828237116