search

fsprojects / FSharpLint

Lint tool for F#
https://fsprojects.github.io/FSharpLint/
MIT License
300 stars 73 forks source link

build: re-enable NU1605 #685

Closed webwarrior-ws closed 4 months ago

webwarrior-ws commented 5 months ago

Re-enabled NU1605 warning. To avoid package downgrades, pinned FSharp.Core and Microsoft.Build.* packages to specific versions.

paket.lock file was updated using dotnet paket update --keep-patch command.

knocte commented 5 months ago

paket.lock file was updated using dotnet paket update command.

Shouldn't you have used the flag --keep-patch? This way the update generates less noise (e.g. not needing to update the System.Text.Json versions line).

webwarrior-ws commented 5 months ago

paket.lock file was updated using dotnet paket update command.

Shouldn't you have used the flag --keep-patch? This way the update generates less noise (e.g. not needing to update the System.Text.Json versions line).

Re-run dotnet paket update with --keep-patch flag.

knocte commented 5 months ago

@webwarrior-ws can you rebase this please? I'll merge the PR after 0.24.2 is released.

webwarrior-ws commented 5 months ago

@webwarrior-ws can you rebase this please? I'll merge the PR after 0.24.2 is released.

rebased

knocte commented 4 months ago

@webwarrior-ws this needs to be rebased again, sorry

webwarrior-ws commented 4 months ago

@webwarrior-ws this needs to be rebased again, sorry

rebased