search

fsprojects / FSharpLint

Lint tool for F#
https://fsprojects.github.io/FSharpLint/
MIT License
303 stars 73 forks source link

Upgrade FSharp.Compiler.Service to v43.8.200 to remove workaround in NoPartialFunctions rule #698

Open webwarrior-ws opened 7 months ago

webwarrior-ws commented 7 months ago

NoPartialFunctions needed a workaround because of a bug in FSharp.Compiler.Service library. In FSharp.Compiler.Service to v43.8.200 that has bug has been fixed.

This PR upgrades FCS to v43.8.200 and makes necessary changes to code. Workaround is removed. Packages FSharp.Core and Ionide.ProjInfo.* also had to be upgraded to latest stable versions.

knocte commented 7 months ago

Even though this doesn't have conflicts, I'd prefer to get a rebase before merging, just to be on the safe side.

webwarrior-ws commented 7 months ago

Even though this doesn't have conflicts, I'd prefer to get a rebase before merging, just to be on the safe side.

Rebased.

knocte commented 7 months ago

Can you move the commit NoPartialFunctions: remove workaround to be the last one please?

webwarrior-ws commented 7 months ago

Can you move the commit NoPartialFunctions: remove workaround to be the last one please?

Done