search

fsprojects / FSharpLint

Lint tool for F#
https://fsprojects.github.io/FSharpLint/
MIT License
300 stars 73 forks source link

Add FavourAsKeyword rule #709

Closed ribeirotomas1904 closed 3 weeks ago

ribeirotomas1904 commented 1 month ago

Add FavourAsKeyword rule and tests and docs for it. Fixes #664

knocte commented 4 weeks ago

Thanks for your contribution!

I'm going to do a quick review, but by the looks of it, most things are just going to be nitpicks; except one: please don't forget do add the new rule config entry in fsharplint.json: https://github.com/fsprojects/FSharpLint/blob/master/src/FSharpLint.Core/fsharplint.json

ribeirotomas1904 commented 3 weeks ago

Thanks for your contribution!

I'm going to do a quick review, but by the looks of it, most things are just going to be nitpicks; except one: please don't forget do add the new rule config entry in fsharplint.json: https://github.com/fsprojects/FSharpLint/blob/master/src/FSharpLint.Core/fsharplint.json

Thanks for the feedback!

config entry for the new rule added in 2f80c7eb45f6d8b80a0580c1ec524bdfc4449f0c